Skip to content

feat ($theme-default): add support for specifying image width and height #578 #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JessicaSachs
Copy link
Collaborator

Summary
This changes makes it easier for people to define absolute width/height dimensions for their images. The issue #578 asks for Vuepress to detect image sizes on build, but this would be a breaking change for many sites that expect their images to be responsive to the parent container. This new feature helps solve the issue present in #578 without requiring a breaking change.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@JessicaSachs JessicaSachs changed the title feat() #578: add support for specifying image width and height feat #578: add support for specifying image width and height Sep 8, 2020
@bencodezen bencodezen changed the title feat #578: add support for specifying image width and height feat ($theme-default): add support for specifying image width and height #578 Sep 8, 2020
@dlecan
Copy link

dlecan commented Dec 22, 2020

That's an interesting feature, why is it blocked?

@adarshmadrecha
Copy link

Any plan to merge this request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants