docs: update node version for gitlab ci config #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is my issue: #2584 I've found that node:9.11.1 is too old and in the `Prerequisites` part of the guide, it's recommend to use node 10+ so update a small comment could be useful. I don't know if it is applicable to delete `node:9.11.1` and replace with `node:14.8.0` so I just add a comment
|
The checks aren't successful because of some errors in other *.md as well |
bencodezen
requested changes
Sep 1, 2020
There was a problem hiding this comment.
Thanks for the PR @loctran016! I actually would recommend just swapping out the node version for the latest node 10.22 instead once you've tested it out.
Let me know if you have any questions!
Although Node v10.22.0 isn't the latest version, the latest and one is node 12.18.3, Node v10.22.0 is still Ok because it's version 10+ so no problem to use it. Anyway, I've updated to Node v10.22.0 |
bencodezen
approved these changes
Sep 1, 2020
bencodezen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my issue: #2584
I've found that node:9.11.1 is too old and in the
Prerequisitespart of the guide, it's recommend to use node 10+ so update a small comment could be useful. I don't know if it is applicable to deletenode:9.11.1and replace withnode:14.8.0so I just add a commentSummary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: