Skip to content

test: add end-to-end tests, fix #2249 #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

flaurida
Copy link

@flaurida flaurida commented Mar 27, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Resolves #2249. Adds initial end-to-end tests of VuePress. Specifically, tests that a user can 1) create a new project, 2) view the project in the browser, 3) add a page to it, and 4) see the updated project in the browser.

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

The end-to-end tests run in Chromium, Firefox, and WebKit as these are the browsers Playwright supports.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

I set up the end-to-end tests to run in GitHub Actions, which is free for open source projects like VuePress. Here is a run on my fork. Below shows the artifacts from the test run.
2020-03-27 11 23 10

However, if you prefer I can port the tests to CircleCI.

In addition, I saved the tests in a new __e2e__ directory. I am happy to move them elsewhere if you like.

Thanks for reviewing, looking forward to your feedback! 😊

@flaurida flaurida changed the title add end-to-end tests, fix #2249[,#2249] add end-to-end tests, fix [#2249](#2249) Mar 27, 2020
@flaurida flaurida changed the title add end-to-end tests, fix [#2249](#2249) add end-to-end tests, fix #2249 Mar 27, 2020
@flaurida flaurida changed the title add end-to-end tests, fix #2249 test: add end-to-end tests, fix #2249 Mar 27, 2020
@flaurida flaurida force-pushed the master branch 6 times, most recently from 82b2bd3 to 9006a68 Compare March 27, 2020 17:28
@flaurida flaurida marked this pull request as ready for review March 27, 2020 17:35
Copy link
Collaborator

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort. I haven't used qawolf before, but I'll have a look later.

Imo, it'll be good to run the tests on Circleci since we're using it already.

@flaurida
Copy link
Author

Thanks for the review, happy to move the tests to CircleCI. Re qawolf, the tests are in Playwright/Jest, and qawolf provides video/logs for the tests when running in CI.

@flaurida
Copy link
Author

Temporarily closing so I can test against CircleCI on my branch. Will re-open once it passes there.

@flaurida
Copy link
Author

Opened #2260 as was not allowed to re-open this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up end-to-end tests?
2 participants