doc: add an example of a fully PWA-compliant config for pwa-plugin #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahdayan
reviewed
Aug 11, 2019
There was a problem hiding this comment.
Hey @kefranabg, I made a few suggestions. Let me know what you think.
Co-Authored-By: Sarah Dayan <dayan.sarah@gmail.com>
Co-Authored-By: Sarah Dayan <dayan.sarah@gmail.com>
Co-Authored-By: Sarah Dayan <dayan.sarah@gmail.com>
Co-Authored-By: Sarah Dayan <dayan.sarah@gmail.com>
|
Way better, thanks for the review @sarahdayan 👍 |
Co-Authored-By: Sarah Dayan <dayan.sarah@gmail.com>
Co-Authored-By: Sarah Dayan <dayan.sarah@gmail.com>
|
I've just done a translation for this |
Co-Authored-By: Billyyyyy3320 <newsbielt703@gmail.com>
Co-Authored-By: Billyyyyy3320 <newsbielt703@gmail.com>
Co-Authored-By: Billyyyyy3320 <newsbielt703@gmail.com>
Co-Authored-By: Billyyyyy3320 <newsbielt703@gmail.com>
|
Hey @kefranabg, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve pwa-plugin doc by adding an example of a fully PWA-compliant config for pwa-plugin.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
Other information:
Need translation for zh.