Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing core team members to README #1766

Merged
merged 4 commits into from
Aug 13, 2019

Conversation

kefranabg
Copy link
Collaborator

Summary

Add missing team members in README.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Copy link
Collaborator

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@bencodezen
Copy link
Member

@kefranabg Hope you don't mind me piggy backing off your PR! Thought it would be easier than a separate PR for someone to review later.

@kefranabg
Copy link
Collaborator Author

Woops! Sorry about that @bencodezen 😛

@bencodezen
Copy link
Member

Woops! Sorry about that @bencodezen 😛

It's all good! Haha

@edisdev
Copy link
Contributor

edisdev commented Aug 10, 2019

Hi ! @kefranabg , Can I add myself too to list? :)

.all-contributorsrc Outdated Show resolved Hide resolved
.all-contributorsrc Outdated Show resolved Hide resolved
@kefranabg kefranabg changed the title Add missing core team members to README docs: add missing core team members to README Aug 13, 2019
@kefranabg kefranabg merged commit 1385dd6 into master Aug 13, 2019
@kefranabg kefranabg deleted the doc/add-missing-core-team-members branch August 13, 2019 20:22
@vue-bot
Copy link

vue-bot commented Aug 13, 2019

Hey @kefranabg, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants