feat: Disable next and prev links from global config #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kefranabg
changed the title
kefranabg
force-pushed
the
feat/theme-links-config
branch
from
42945e4
to
01f5b0c
Compare
sarahdayan
suggested changes
Aug 11, 2019
sarahdayan
approved these changes
Aug 13, 2019
| // custom text for edit link. Defaults to "Edit this page" | ||
| editLinkText: 'Help us improve this page!' | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| You can also hide the edit link on a specific page via `YAML front matter`: | ||
| You can overwrite the following properties on specific pages via `YAML front matter`: | ||
|
|
||
| ``` yaml | ||
| --- |
There was a problem hiding this comment.
It has already been mentioned in the previous section.
There was a problem hiding this comment.
Yes but I think it's a good thing to also mention it here as users won't necessarily have read this part before.
There was a problem hiding this comment.
I mean maybe you can update Prev / Next Links to tell folks that they can disable next and prev links from global config ( Instead of updating Git repository and Edit Links). Just my opinion.
There was a problem hiding this comment.
Sure! I can update both parts indeed 😉
kefranabg
changed the title
|
Hey @kefranabg, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1727
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: