fix(@plugin-blog): fix blog layout rendering error (close: #1073) #1095
Conversation
| @@ -111,7 +111,7 @@ module.exports = class AppContext { | |||
| }) | |||
| ) | |||
|
|
|||
| await this.pluginAPI.options.ready.apply() | |||
| await this.pluginAPI.options.ready.asyncApply() | |||
There was a problem hiding this comment.
Actually the apply method of a asynchronous option was a alias of asyncApply: https://github.com/vuejs/vuepress/blob/master/packages/%40vuepress/core/lib/plugin-api/abstract/AsyncOption.js#L93
|
|
||
| if (typeof this.frontmatter.layout === 'string') { | ||
| this._hasInitLayout = true | ||
| } | ||
| } |
There was a problem hiding this comment.
You can use datatypes: { isString } from shared-utils directly.
| rawFrontmatter[key] = rawFrontmatter[key] || frontmatter[key] | ||
| if (!pageCtx._hasInitLayout) { | ||
| rawFrontmatter[key] = frontmatter[key] | ||
| } |
There was a problem hiding this comment.
Maybe it would block the apply of other attrs (e.g. permalink ) in frontmatter ? actually I think the following override strategy should be right —— we should respect all the attrs which has been set in user's frontmatter.
if (!frontmatter[key]) {
rawFrontmatter[key] = frontmatter[key]
}There was a problem hiding this comment.
Yes, I ignored this question.
There was a problem hiding this comment.
vuepress/packages/@vuepress/plugin-blog/index.js
Lines 68 to 70 in e01e60a
Is this setting a bit problematic?
There was a problem hiding this comment.
I corrected this by the way.
|
Another FYI, actually the |
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
The new page of the blog plugin cannot be used because the getSiteData method has been executed before the plugin ready.