Skip to content

URL hash and sidebar item don't set correctly for short sections #865

Closed
@padarom

Description

@padarom

Bug report

When clicking on the headline of a short section within the sidebar, the URL hash and selected sidebar items don't change correctly.

Version

0.14.4, also tested on 0.12.0

Steps to reproduce

  • Create a page where the last section is too short to scroll past its header. The first section has to be long enough so the page has a scroll bar
  • Click the sidebar link of the last section

(or try it out by clicking on "Webhooks" there: https://blurple.js.org/runtime/configuration.html)

What is expected?

  • The URL hash changes to the heading you clicked on
  • The active sidebar item changes to the heading you clicked on

What is actually happening?

The URL hash and active sidebar items change, but immediately revert back to a section above.

When clicking the sidebar item again, without scrolling beforehand, the hash and active sidebar items are set correctly and don't revert.

When clicking the sidebar the first time, the page scrolls down to that section. Immediately the scroll event kicks in and sets the active sidebar item and hash to a section above. When the item is clicked again, the page is already scrolled to that section, so the scroll event doesn't fire again and the hash/active item remain set correctly.

Other relevant information

  • Your OS: macOS 10.13.6
  • Node.js version: v10.7.0
  • Browser version: Google Chrome 69.0.3497.100
  • Is this a global or local install? local
  • Which package manager did you use for the install? npm

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions