Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar headers not being detected when after other content (i.e. image) #841

Closed
rwxrob opened this issue Sep 14, 2018 · 2 comments
Closed
Labels
type: bug Something isn't working

Comments

@rwxrob
Copy link

rwxrob commented Sep 14, 2018

Bug report

I appears headers are not detected for sidebar: auto configuration unless they are the first or near the first of the document. This seems to be a bug since many will want to place an image or other introductory text and versions before the first header.

Version

0.14.2

Steps to reproduce

screen shot 2018-09-14 at 3 54 57 pm

screen shot 2018-09-14 at 3 55 10 pm

For those wanting a work around to this issue you can force the sidebar using the explicit variation of the sidebar configuration instead of just auto but it would be nice if auto did what most might expect.

What is expected?

I was expecting this to auto detect the level 1 header even though it comes after the image.

What is actually happening?

The image is causing the header not being detected.

Other relevant information

  • Your OS: Mac Os
  • Node.js version: v10.9.0
  • Browser version: Chrome Version 69.0.3497.92 (Official Build) (64-bit)
  • Is this a global or local install? global
  • Which package manager did you use for the install? yarn
@ulivz ulivz added the type: bug Something isn't working label Sep 15, 2018
@ulivz ulivz closed this as completed in 181c1e5 Sep 15, 2018
@ulivz ulivz added the resolved label Sep 15, 2018
@ulivz
Copy link
Member

ulivz commented Sep 15, 2018

Release at @0.14.4.

@rwxrob
Copy link
Author

rwxrob commented Sep 15, 2018

Well at least something seemed useful coming from me in the last week or so. 😁 I really appreciate all your work on this and look forward to contributing more substantially in the future. I believe I could really help with documentation if that is something you need immediately. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants