Skip to content

[feat] Allow override.styl for all themes, not just the default #404

Closed
@ghys

Description

@ghys

Following the discussion in #339 (comment):

I would simply like to suggest removing the options.useDefaultTheme check here:

const hasUserOverride = options.useDefaultTheme && fs.existsSync(overridePath)

The benefit would be to still be able to change Stylus variables like $accentColor when making small modifications to the default theme, for example adding a component to a slot of the default Layout:

<template>
  <Layout>
    <PageFooter slot="page-bottom" />
  </Layout>
</template>

<script>
import Layout from '@default-theme/Layout.vue'
import PageFooter from 'PageFooter.vue'

export default {
  components: {
    Layout,
    PageFooter
  }
}
</script>

Other custom themes could also allow local overrides by having @import '~@temp/override.styl' in their style. If not the file would still be copied in app/.temp but won't have any effect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions