-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route/Page Transition #1884
Comments
What kind of transition are you thinking about? |
Fade in and out |
Hello! We get a lot of issues, so we currently close issues requiring feedback after 20 days of inactivity. It’s been at least 10 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. (A maintainer can also add the label Thanks for being a part of the Vue community! 💪💚️ |
I can work on this :) |
@CodesOfRa are you still planning to work on this? I'm considering writing a plugin from scratch, but don't want to duplicate your work, especially if there's any work I could do to help. The simplest implementation I've come up with so far would just involve adding a Vue component as a parent of the GlobalLayout, which (if I understand correctly) should handle timing and expose the right CSS classes using the default Vue transition system. |
A much-refined proof-of-concept version of the idea I describe, written by @jdtzmn as a patch rather than a plugin, is here: https://github.com/jdtzmn/vuepress This implementation would also meet #2098, I think (@axieum confirm?). It allows for any custom root combination of Vue components to replace the default router setup. Tomorrow, I'll try to get an example live. If this is a useful feature, I can document/test/refactor @jdtzmn's code as needed. |
Yes, this appears to solve #2098, however will need modifying to remove a couple set in stone elements; see comment on commit jdtzmn/vuepress@aa638ee#r36658709 If this is implemented, this will allow us to completely modify the Vue instance (using enhanceApp and CustomRouter view). |
@axieum can you describe your use case for those additional modifications? |
I just implemented |
The issue is that, to implement smooth transitions between different routes (and, therefore, layouts) requires including a direct parent of the router-view Vue element and specifying transitions in the same Vue file. |
Hi 👋 @sdaitzman I am still planning to work on this, but I am a bit busy at the moment so if you have the time feel free to take it over |
@CodesOfRa thanks for letting me know! Do you have any work-in-progress somewhere that I could start from? |
Feature request
Is it in the roadmap to add page transitions to VuePress?
What problem does this feature solve?
Beautify the transition between pages
The text was updated successfully, but these errors were encountered: