Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route/Page Transition #1884

Open
pxwee5 opened this issue Sep 23, 2019 · 12 comments
Open

Route/Page Transition #1884

pxwee5 opened this issue Sep 23, 2019 · 12 comments
Assignees
Labels
contribution welcome Contributions welcome type: feature request Request to add a new feature

Comments

@pxwee5
Copy link

pxwee5 commented Sep 23, 2019

Feature request

Is it in the roadmap to add page transitions to VuePress?

What problem does this feature solve?

Beautify the transition between pages

@kefranabg kefranabg added type: feature request Request to add a new feature contribution welcome Contributions welcome labels Sep 23, 2019
@kefranabg
Copy link
Collaborator

What kind of transition are you thinking about?

@kefranabg kefranabg added the need feedback Awaiting author response label Oct 3, 2019
@gevera
Copy link

gevera commented Oct 12, 2019

Fade in and out

@vue-bot
Copy link

vue-bot commented Oct 22, 2019

Hello!
This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues requiring feedback after 20 days of inactivity. It’s been at least 10 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. (A maintainer can also add the label not stale to keep this issue open.)

Thanks for being a part of the Vue community! 💪💚️

@CodesOfRa
Copy link
Collaborator

I can work on this :)

@kefranabg kefranabg removed the need feedback Awaiting author response label Oct 24, 2019
@sdaitzman
Copy link

sdaitzman commented Jan 3, 2020

@CodesOfRa are you still planning to work on this? I'm considering writing a plugin from scratch, but don't want to duplicate your work, especially if there's any work I could do to help.

The simplest implementation I've come up with so far would just involve adding a Vue component as a parent of the GlobalLayout, which (if I understand correctly) should handle timing and expose the right CSS classes using the default Vue transition system.

@sdaitzman
Copy link

A much-refined proof-of-concept version of the idea I describe, written by @jdtzmn as a patch rather than a plugin, is here: https://github.com/jdtzmn/vuepress

This implementation would also meet #2098, I think (@axieum confirm?). It allows for any custom root combination of Vue components to replace the default router setup.

Tomorrow, I'll try to get an example live. If this is a useful feature, I can document/test/refactor @jdtzmn's code as needed.

@axieum
Copy link

axieum commented Jan 4, 2020

Yes, this appears to solve #2098, however will need modifying to remove a couple set in stone elements; see comment on commit jdtzmn/vuepress@aa638ee#r36658709

If this is implemented, this will allow us to completely modify the Vue instance (using enhanceApp and CustomRouter view).

@sdaitzman
Copy link

@axieum can you describe your use case for those additional modifications?

@axieum
Copy link

axieum commented Jan 19, 2020

I just implemented Content level transitions very easily. I'm assuming this issue is related to being able to transition upper level elements closer to the #app?

@sdaitzman
Copy link

The issue is that, to implement smooth transitions between different routes (and, therefore, layouts) requires including a direct parent of the router-view Vue element and specifying transitions in the same Vue file.

@CodesOfRa
Copy link
Collaborator

Hi 👋 @sdaitzman I am still planning to work on this, but I am a bit busy at the moment so if you have the time feel free to take it over

@sdaitzman
Copy link

@CodesOfRa thanks for letting me know! Do you have any work-in-progress somewhere that I could start from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome type: feature request Request to add a new feature
Projects
None yet
Development

No branches or pull requests

7 participants