-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm install
and npm test
to CI
#1452
Labels
contribution welcome
Contributions welcome
Comments
Contribution welcome! |
@jamesgeorge007 Let go for it! |
@ulivz As per what I see adding an |
This was referenced Jun 18, 2022
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature request
Add
npm install
andnpm test
to the CircleCI build scripts.What problem does this feature solve?
Currently, the website's front-page implicitly suggests that
npm i -g vuepress
should work just as well asyarn global add vuepress
:It would be awesome to get that same assertion of support in the CI builds so that y'all can ensure there are no possible npm CLI issues before they may be shipped.
The way Yarn and npm resolve dependencies is slightly differently – meaning of the yarn CLI could have a totally fine experience but npm CLI could have an absolutely horrible one. Additionally, Yarn makes no guarantees that dependency resolution will only change with semver major release which only exacerbates this concern as an npm CLI user.
How should this be implemented in your opinion?
Probably as a secondary CI build – i.e. not in the same container as Yarn builds – so you don't have cross-contamination between the two builds.
Are you willing to work on this yourself?
Would be happy to!
The text was updated successfully, but these errors were encountered: