Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving license clarity of simplehtmlparser.js #9907

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Conversation

hyandell
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: License documentation

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The licensing in src/compiler/parser/html-parser.js is described as "Mozilla Public License", which will cause flags of concern for some reviewers as it takes Vue from being an MIT licensed project to a project containing copyleft licensing. This is unnecessary as the original code appears to have an option of three licenses. I've updated the text to describe the three licenses using SPDX license expression format.

@yyx990803 yyx990803 merged commit 29e745f into vuejs:dev Apr 23, 2019
@vue-bot
Copy link
Contributor

vue-bot commented Apr 23, 2019

That's amazing! @hyandell, we just merged your PR to vue! Thank you for your time! 💚

Tweet it

kiku-jw pushed a commit to kiku-jw/vue that referenced this pull request Jun 18, 2019
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants