-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support v-on passive modifier #5132
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2bf2a64
support v-on passive modifier
ad844ff
fix supportsPassive and run unit when the test browser supports
9fa45fa
add mutual exclusive warning
77db11c
Fix typo
posva c333c6e
Fix typo
posva d0b56b9
Merge branch 'dev' into dev-passive
znck 0329bcf
Remove extra line - CS fix
znck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
import Vue from 'vue' | ||
import { supportsPassive } from 'core/util/env' | ||
|
||
describe('Directive v-on', () => { | ||
let vm, spy, spy2, el | ||
|
@@ -526,4 +527,36 @@ describe('Directive v-on', () => { | |
expect(spyUp.calls.count()).toBe(1) | ||
expect(spyDown.calls.count()).toBe(1) | ||
}) | ||
|
||
// This test case should only run when the test browser supports passive. | ||
if (supportsPassive) { | ||
it('should support passive', () => { | ||
vm = new Vue({ | ||
el, | ||
template: ` | ||
<div> | ||
<input type="checkbox" ref="normal" @click="foo"/> | ||
<input type="checkbox" ref="passive" @click.passive="foo"/> | ||
<input type="checkbox" ref="exclusive" @click.prevent.passive/> | ||
</div> | ||
`, | ||
methods: { | ||
foo (e) { | ||
e.preventDefault() | ||
} | ||
} | ||
}) | ||
|
||
vm.$refs.normal.checked = false | ||
vm.$refs.passive.checked = false | ||
vm.$refs.exclusive.checked = false | ||
vm.$refs.normal.click() | ||
vm.$refs.passive.click() | ||
vm.$refs.exclusive.click() | ||
expect(vm.$refs.normal.checked).toBe(false) | ||
expect(vm.$refs.passive.checked).toBe(true) | ||
expect(vm.$refs.exclusive.checked).toBe(true) | ||
expect('passive and prevent can\t be used together. Passive handler can\'t prevent default event.').toHaveBeenWarned() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. needs minor fix for above suggested text change. |
||
}) | ||
} | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing literal (
'
) incan\t