fix root v-else not rendering in prod and switched examples to minified vue for better prod coverage #3943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3940. This was a bit of a brainless error on my part - I apologize. Something I noticed however, is that none of our tests are currently covering the production build of Vue, thus allowing this error to slip through. To prevent this in the future, I was wondering if we should split the unit tests into two groups:
NODE_ENV
set toproduction
I think that work would be well outside the scope of this PR, but as a stop-gap measure to cover production at least a little, I switched all of the e2e examples to use the production build, then tweaked the grid example so that I could add a regression test.
My thinking is that production is probably most important for e2e anyway, as devs will more quickly discover development-only errors (and they won't affect end users). The only downside I can foresee is that if someone clones the repo to start playing with examples, they won't get any nice warnings if they make a mistake. So, I added a comment above each Vue script with instructions to use the development version if they'd like. Still, I'm happy to change it back if this is undesirable. We'd just have to think of another way to add a regression test.
One last unrelated note: while updating the examples, I noticed that the todomvc's HTML file was full of tabs rather than spaces, so I converted them for consistency.