Skip to content

Add Vue context to computed options type (fix #10878) #12218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

okj579
Copy link

@okj579 okj579 commented Aug 13, 2021

Vue passes the Vue object as the first parameter, which is useful for arrow functions. This change reflects that in the types.

Fixes #10878

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Vue passes the Vue object as the first parameter, which is useful for arrow functions. This change reflects that in the types.

Fixes vuejs#10878
@posva
Copy link
Member

posva commented Aug 13, 2021

Thank you but this is not exactly what should be passed. What should be passed is the type of the component to get access to other data and computed properties. Note it might not be possible to support fully so the issue might not be really fixable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support computed as arrow function in typescript
2 participants