Skip to content

Conversation

LongTengDao
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

I found that new ( Vue.extend({}) )() and components inside will work right, just void to new Vue({}) (root case), things will be ok.

So at least fix the propsData line, that will cause bug when prop is declared but no prop pass in (vm will get function on proto, not undefined nor default), that's easy to fix, and can't avoid like above in userland.

@sirlancelot
Copy link

sirlancelot commented Nov 9, 2020

I suspect you'll encounter many issues more than just this if your codebase (or other third-party lib) is polluting Object.prototype.

@posva
Copy link
Member

posva commented Nov 9, 2020

I already answered this...

@posva posva closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants