Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video attribute 'muted' not applied in Firefox #6887

Closed
madsfaerch opened this issue Oct 23, 2017 · 7 comments
Closed

Video attribute 'muted' not applied in Firefox #6887

madsfaerch opened this issue Oct 23, 2017 · 7 comments

Comments

@madsfaerch
Copy link

Version

2.5.2

Reproduction link

https://codepen.io/madsfaerch/pen/XewjNb

Steps to reproduce

  1. The pen consists of a simple Vue instance mounted to #app containing a video element with muted="muted".
  2. Open the pen in Chrome and notice that the volume icon is set to muted and the video is muted when played.
  3. Open the pen in Firefox and notice that the volume icon is set to unmuted and the video is unmuted when played.

What is expected?

That the video plays muted and controls show muted.

What is actually happening?

The video plays unmuted and the controls show unmuted. This is especially an issue with autoplaying videos.


Reproduced in Firefox 56.0 and FirefoxDeveloperEdition 57.0b10 on different machines running either macOS Sierra or High Sierra.

@HerringtonDarkholme
Copy link
Member

Curiously you can use <video :muted="true"> to force vuejs to render dom props.

@HerringtonDarkholme
Copy link
Member

Reduced reproduction:

var a = document.createElement('video')
a.setAttribute('muted', true)
a.setAttribute('controls', true)
a.innerHTML = '<source src="https://tyfc.co/static/videos/bill.webm" type="video/webm"></source>'
document.body.appendChild(a)

Firefox won't respect attribute set on video later.

@posva
Copy link
Member

posva commented Oct 23, 2017

@HerringtonDarkholme Is this a Firefox problem then?

@madsfaerch
Copy link
Author

Curiously you can use

@HerringtonDarkholme Thanks for this. I will use it for the time being.

Is the next step to file a bug with Firefox?

@posva
Copy link
Member

posva commented Oct 24, 2017

I don't think it's a firefox bug actually.
Vue should keep muted without a value, but it's weird because there's also a warning for muted to be used with the prop modifier in the code but it doesn't seem to trigger

lovelope pushed a commit to lovelope/vue that referenced this issue Feb 1, 2018
f2009 pushed a commit to f2009/vue that referenced this issue Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this issue Aug 19, 2020
@HCuma

This comment was marked as outdated.

@matthiasPOE
Copy link

if someone having this error again you should use :muted="ref(true)", but make sure that u imported ref from vue.

Unfortunately this doesnt work for me. Cant get muted to be rendered out to the video element at all still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants