Skip to content

Docs: Add propsData to Mounting Options #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2018

Conversation

sagalbot
Copy link
Contributor

@sagalbot sagalbot commented Aug 15, 2018

Changes

  • Add propsData documentation to mounting options
  • Add link to functional component definition in context description
  • Fix broken link to parentComponent

Notes

  • I used the ::: tip container, but I don't see it used elsewhere. Happy to remove that if preferred.

Closes #917

```

::: tip
It's worth noting that `propsData` is actually a [Vue API](https://vuejs.org/v2/api/#propsData), not a proprietary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanation, although can you remove the word proprietary, it sounds too formal. So:

It's worth noting that propsDatais actually a [Vue API](https://vuejs.org/v2/api/#propsData), not avue-test-utils option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger that, done.

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :)

@eddyerburgh eddyerburgh merged commit f592acc into vuejs:dev Aug 16, 2018
@sagalbot
Copy link
Contributor Author

Happy to help! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants