-
Notifications
You must be signed in to change notification settings - Fork 665
Improve types for mocks and provide in config options #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this PR complete? |
Yes it is! However I'm still confused about the signaturee of |
No, it's an object that's merged into component instance methods. The example is confusing, can you please replace it with this:
|
If it's an object then the docs are not correct as:
Is equivalent to:
If we wanted an object the docs should be as follows:
Note the parenthesis. |
Yes that's why I asked if you could replace the example. As you said, it's incorrect. |
Aaah, alright then! I'll change it then |
Can you fix the linting error please? |
Done, ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks :)
This PR allows users of TypeScript to use bracket notation without the need to cast to
any
.Before:
After:
Also, continuing work from this PR: #874, I set
allowSyntheticDefaultImports
to true in order to import default export without errors.