chore: remove gh-pages #1388
Merged
chore: remove gh-pages #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CNAME is for GHpages to allow domain binding. Netlify should not need it. |
dobromir-hristov
approved these changes
Jan 3, 2020
|
PRs that reduce total amount of code - my favorite kind. |
lmiller1990
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes GH pages, which are unneeded because we deploy docs via Netlify on any merge to the dev branch.
After merging this PR, we can delete the
gh-pagesbranch.One thing I'm a bit uncertain of is if
docs/assets/CNAMEanddocs/assets/circle.ymlare used in some other way. The code doesn't have any references after deletingscripts/update-docs.sh, but I'm still paranoid.Thoughts?