-
Notifications
You must be signed in to change notification settings - Fork 665
Adding get method to Wrapper #1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lmiller1990
merged 7 commits into
vuejs:dev
from
tomasbjerre:feature/issue-1298-get-method-on-wrapper
Jan 16, 2020
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ea39a3f
Adding get method to Wrapper #1298
tomasbjerre 7e3f227
Documenting get method on wrapper #1298
tomasbjerre b41b951
Adjusting docs on get method on wrapper #1298
tomasbjerre 726262c
docs: update
lmiller1990 a4ca2a1
chore: merge in dev
lmiller1990 a34e5b1
chore: resolve conflict
lmiller1990 5ee369c
docs: linting
lmiller1990 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
## get | ||
|
||
Works just like [find](../find.md) but will throw an error if nothing matching | ||
the given selector is found. You should use `find` when searching for an element | ||
that may not exist. You should use this method when getting an element that should | ||
exist and it will provide a nice error message if that is not the case. | ||
|
||
```js | ||
import { mount } from '@vue/test-utils' | ||
|
||
const wrapper = mount(Foo) | ||
|
||
// similar to `wrapper.find`. | ||
// `get` will throw an error if an element is not found. `find` will do nothing. | ||
expect(wrapper.get('.does-exist')) | ||
|
||
expect(() => wrapper.get('.does-not-exist')) | ||
.to.throw() | ||
.with.property( | ||
'message', | ||
'Unable to find .does-not-exist within: <div>the actual DOM here...</div>' | ||
) | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { compileToFunctions } from 'vue-template-compiler' | ||
import { describeWithShallowAndMount } from '~resources/utils' | ||
|
||
describeWithShallowAndMount('get', mountingMethod => { | ||
it('throws describing error when element not found', () => { | ||
const compiled = compileToFunctions('<div/>') | ||
const wrapper = mountingMethod(compiled) | ||
expect(() => wrapper.get('.does-not-exist')) | ||
.to.throw() | ||
.with.property( | ||
'message', | ||
'Unable to find .does-not-exist within: <div></div>' | ||
) | ||
}) | ||
it('gets the element when element is found', () => { | ||
const compiled = compileToFunctions('<div class="does-exist"><div>') | ||
const wrapper = mountingMethod(compiled) | ||
expect(wrapper.get('.does-exist')).to.be.an('object') | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.