Use same code for HMR with shadowMode #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sodatea Requesting some visibility here. Thanks! |
|
@gslama-akqa My pleasure. I have this fix published at https://www.npmjs.com/package/@alancnet/vue-style-loader if you need it. |
|
File lib/addStylesShadow.js was deleted but vue/cli-service/lib/commands/build/resolveWcEntry.js tries to import it. So building production build fails but HMR works correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Prior to this change,
addStylesToShadowDOMwould ignore styles it had already added. When developing using Hot Module Reload, it is necessary to replace existing style elements instead.Did you add tests for your changes?
No, there are no existing tests for
addStylesShadow.js. Perhaps there should be, but the changes would be larger than the scope of this PR.If relevant, did you update the README?
No, the README does not reference shadow mode at all. Perhaps it should, but the changes would be larger than the scope of this PR.
Summary
I use HMR in my projects, and templates update as expected. Styles do not. This solves #38
Does this PR introduce a breaking change?
This is not a breaking change.
Other information