Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn v2 compatibility: add vue-template-compiler as a peerDependency #1639

Closed
AlexandreBonaventure opened this issue Feb 11, 2020 · 0 comments · Fixed by freaktechnik/twaese#25 · May be fixed by cherrypoppins226/tfjs-linear-regression-demo#5
Closed

Yarn v2 compatibility: add vue-template-compiler as a peerDependency #1639

AlexandreBonaventure opened this issue Feb 11, 2020 · 0 comments · Fixed by freaktechnik/twaese#25 · May be fixed by cherrypoppins226/tfjs-linear-regression-demo#5

Comments

@AlexandreBonaventure
Copy link

Version

15.8.3

I understand the reasoning behind vue-loader not requiring vue-template-compiler for version pinning, but I would argue that it should still be listed as a peerDependency. With yarn v2 enforcing strict dependency tree, this is currently throwing an error.
Is there any reason why it has been removed at all ?

commit ref 7e5862c#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

global vue-cli issue for ref: vuejs/vue-cli#5135

What is expected?

vue-template-compiler listed as a peerDependency

What is actually happening?

it is not
@AlexandreBonaventure AlexandreBonaventure changed the title https://github.com/vuejs/vue-loader/commit/7e5862c3bdf74759069cdb3d53f6e4bc17e3c643#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 vue-template-compiler should be a peerDependency. Yarn v2 compatibility Feb 11, 2020
@AlexandreBonaventure AlexandreBonaventure changed the title vue-template-compiler should be a peerDependency. Yarn v2 compatibility Yarn v2 compatibility: add vue-template-compiler as a peerDependency Feb 11, 2020
AlexandreBonaventure added a commit to AlexandreBonaventure/workspace-yarn2-example that referenced this issue Feb 12, 2020
@AlexandreBonaventure
remove vue-loader patch (fixed vuejs/vue-loader#1639)
f0bf274 
vuejs/vue-loader#1639
@snyk-bot snyk-bot mentioned this issue Mar 29, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@AlexandreBonaventure