custom block with es6 content

[dunkfordyce]

Version

13.5.0

Reproduction link

https://github.com/dunkfordyce/custom-block-es6

Steps to reproduce

Run the sample repo as usual. The custom block foo has a loader build/foo-loader.js. The code exports a default function to modify the Component. Because the code is ES6 the function is never run as the loader does not check for an ES6 module, it sees an object instead of a function.

What is expected?

The default exported function should be run.

What is actually happening?

The vue-loader code sees an object instead of a function.

[LinusBorg]

I'm not sure if I misunderstand something, but the foo loader doesn't actually do anything:

module.exports = function (source, map) {
    this.callback(null, source, map);
};

Did you push the wrong branch or something? Or is my lack of knowledge about loader internals showing?

[Jinjiang]

@LinusBorg I guess I get the point. The <foo>export default function () { ... }</foo> cannot be recognized as a function in runtime but an object with a default function property.

But <foo>module.exports = function () { ... }</foo> always works with that "doing-nothing" loader.

So if we do a little change with the generated code:

if (typeof customBlock === "function") {  customBlock(Component)}

The es6 content maybe also work.

I would create a PR soon if you don't mind.

Thanks.

[yyx990803]

closed via #1081