Skip to content

Avoid parsing LESS, PostCSS too #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Avoid parsing LESS, PostCSS too #58

merged 1 commit into from
Feb 20, 2018

Conversation

hmsk
Copy link
Contributor

@hmsk hmsk commented Feb 20, 2018

Other than Sass/SCSS, we may face parsing errors with cssExtract.extractClasses(cssCode); in processStyle (stylePart, filePath) if you give code which is invalid as pure CSS. css module can't parse.

like

.testPostcCSS {
  body {
    @media screen {
      background-color: red;
    }
  }
}

This syntax is allowed for almost CSS preprocessors. Anyway, some other syntaxes may make an exception with css module. So, I just added exts to ignore compilation.

@eddyerburgh
Copy link
Member

Thanks 😀

@eddyerburgh eddyerburgh merged commit c26db3b into vuejs:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants