Skip to content

fix: functional component memory leak #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: functional component memory leak #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ if (typeof window !== 'undefined') {
let installed = false
let isBrowserify = false
let initHookName = 'beforeCreate'
const instancesMap = new WeakMap()

exports.install = (vue, browserify) => {
if (installed) return
Expand Down Expand Up @@ -79,6 +80,8 @@ function makeOptionsHot(id, options) {
const instances = map[id].instances
if (ctx && instances.indexOf(ctx.parent) < 0) {
instances.push(ctx.parent)
const ids = instancesMap.get(ctx.parent)
ids && ids.push(id)
}
return render(h, ctx)
}
Expand All @@ -89,10 +92,17 @@ function makeOptionsHot(id, options) {
record.Ctor = this.constructor
}
record.instances.push(this)
if (!instancesMap.has(this)) {
instancesMap.set(this, [])
}
})
injectHook(options, 'beforeDestroy', function() {
const instances = map[id].instances
instances.splice(instances.indexOf(this), 1)
instancesMap.get(this).forEach(functionalId =>{
map[functionalId].instances.splice(instances.indexOf(this), 1)
})
instancesMap.delete(this)
})
}
}
Expand Down