Skip to content

fix: hide warnings about memory leaks #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2019
Merged

fix: hide warnings about memory leaks #44

merged 1 commit into from
Apr 21, 2019

Conversation

sawa-zen
Copy link
Contributor

@sawa-zen sawa-zen commented Apr 17, 2019 •
edited
Loading

A warning was issued to set setMaxListeners from EventEmitter, and I fixed to hide the warning.

↓example

$ npm run lint

> ci-eslint@1.0.0 lint /Users/sawa-zen/develop/sandbox/ci-eslint
> eslint --ext .js,.vue --ignore-path .gitignore .

(node:92395) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 VElement listeners added. Use emitter.setMaxListeners() to increase limit

sawa-zen
sawa-zen commented Apr 17, 2019
View reviewed changes
src/parser-services.ts
if (emitter == null) {
emitters.set(rootAST, (emitter = new EventEmitter()))
emitter = new EventEmitter()
emitter.setMaxListeners(0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This defines unlimited listeners http://nodejs.org/docs/v0.4.7/api/events.html#emitter.setMaxListeners

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, where ai find this file? I'm this error later install the plugin eslint-config-vuetify. thanks

@sawa-zen sawa-zen mentioned this pull request Apr 17, 2019
Closed
mysticatea
mysticatea approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 7d72969 into vuejs:master Apr 21, 2019
@sawa-zen sawa-zen deleted the hide-warnings-about-memory-leak branch April 21, 2019 14:18
@sawa-zen sawa-zen mentioned this pull request May 17, 2019
Merged
@KaelWD KaelWD mentioned this pull request Aug 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mysticatea mysticatea mysticatea approved these changes

+1 more reviewer

@elinardo10 elinardo10 elinardo10 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accepted bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sawa-zen @mysticatea @elinardo10