clean cached template in downloadandgenerate #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2017
egoist
requested changes
May 7, 2017
bin/vue-init
Outdated
| @@ -141,6 +142,8 @@ function run () { | |||
| function downloadAndGenerate (template) { | |||
| var spinner = ora('downloading template') | |||
| spinner.start() | |||
| // check if template is local | |||
There was a problem hiding this comment.
Should use a proper comment, eg: Remove if local template exists
This was referenced Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the currently cached template when we are doing a download and generate.
This helps to resolve #403 where using the --clone flag with private repos fails when the cached template directory already exists.
It also helps resolve #409 where init results in a template that is outdated.