Skip to content

Commit

Permalink
fix(ui): eslint no-console warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Guillaume Chau committed May 11, 2018
1 parent b8f8dad commit d4f41fc
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/@vue/cli-ui/src/components/ClientAddonLoader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export default {
methods: {
loadAddon (addon) {
// eslint-disable-next-line no-console
console.log(`[UI] Loading client addon ${addon.id} (${addon.url})...`)
const script = document.createElement('script')
script.setAttribute('src', addon.url)
Expand Down
1 change: 1 addition & 0 deletions packages/@vue/cli-ui/src/components/FileDiffView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ export default {
this.refresh()
this.$emit('continue')
} catch (e) {
// eslint-disable-next-line no-console
console.error(e)
}
this.loading--
Expand Down
1 change: 1 addition & 0 deletions packages/@vue/cli-ui/src/components/LocaleLoader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export default {
methods: {
loadLocale (locale) {
// eslint-disable-next-line no-console
console.log(`[UI] Locale ${locale.lang} updated with new strings`)
mergeLocale(locale.lang, locale.strings)
}
Expand Down
1 change: 1 addition & 0 deletions packages/@vue/cli-ui/src/components/ProjectPluginItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export default {
}
})
} catch (e) {
// eslint-disable-next-line no-console
console.error(e)
}
this.updating = false
Expand Down
1 change: 1 addition & 0 deletions packages/@vue/cli-ui/src/i18n.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ async function autoDetect () {
if (lang !== 'en') {
await autoInstallLocale(lang)
i18n.locale = lang
// eslint-disable-next-line no-console
console.log(`[UI] Automatically loaded ${lang} locale`)
}
}
Expand Down
3 changes: 3 additions & 0 deletions packages/@vue/cli-ui/src/util/ClientAddonApi.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export default class ClientAddonApi {
this.components.set(id, definition)
const componentId = toComponentId(id)
Vue.component(componentId, definition)
// eslint-disable-next-line no-console
console.log(`[ClientAddonApi] Registered ${componentId} component`)
// Call listeners
const listeners = this.componentListeners.get(id)
Expand Down Expand Up @@ -48,6 +49,7 @@ export default class ClientAddonApi {
children: routes
}
])
// eslint-disable-next-line no-console
console.log(`[ClientAddonApi] Registered new routes under the /addon/${id} route`)
}

Expand All @@ -59,6 +61,7 @@ export default class ClientAddonApi {
*/
addLocalization (lang, strings) {
mergeLocale(lang, strings)
// eslint-disable-next-line no-console
console.log(`[ClientAddonApi] Registered new strings for locale ${lang}`)
}

Expand Down
1 change: 1 addition & 0 deletions packages/@vue/cli-ui/src/views/ProjectCreate.vue
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,7 @@ export default {
this.$router.push({ name: 'project-home' })
this.reset()
} catch (e) {
// eslint-disable-next-line no-console
console.error(e)
}
}
Expand Down
4 changes: 4 additions & 0 deletions packages/@vue/cli-ui/src/views/ProjectPluginsAdd.vue
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ export default {
})
this.tabId = 'config'
} catch (e) {
// eslint-disable-next-line no-console
console.error(e)
}
},
Expand All @@ -282,6 +283,7 @@ export default {
})
this.cancelInstall()
} catch (e) {
// eslint-disable-next-line no-console
console.error(e)
}
},
Expand All @@ -296,6 +298,7 @@ export default {
})
this.tabId = 'diff'
} catch (e) {
// eslint-disable-next-line no-console
console.error(e)
}
},
Expand All @@ -307,6 +310,7 @@ export default {
})
this.close()
} catch (e) {
// eslint-disable-next-line no-console
console.error(e)
}
},
Expand Down

0 comments on commit d4f41fc

Please sign in to comment.