Skip to content

feat(theme): prevent closing local search box on key enter #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brc-dd merged 1 commit into from
Sep 10, 2023
Merged

feat(theme): prevent closing local search box on key enter #2933

brc-dd merged 1 commit into from
Sep 10, 2023

Conversation

@userquin
Copy link
Member

@userquin userquin commented Sep 10, 2023

The local search dialog shouldn't be closed when:

  • key enter on input search
  • key enter on details button
  • key enter on reset search button

@brc-dd brc-dd merged commit e544b41 into main Sep 10, 2023
@brc-dd brc-dd deleted the userquin/fix-enter-in-local-searchbox branch September 10, 2023 14:57
@g-dx g-dx mentioned this pull request Sep 10, 2023
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@userquin @brc-dd