feat(theme): Added two slots for content #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for some extra theming abilities, such as a wide header for a page.
JohnCampionJr
changed the title
JohnCampionJr
changed the title
Moved the slots into the page and docs components
brc-dd
reviewed
Mar 25, 2023
Allow pushing the aside down to make room for the content-before if needed
|
Code looks fine to me, but do you have any other suggestions for slot name? Maybe |
Good point on the naming; Could make two separate ones |
Yeah let's do that 👍 |
brc-dd
reviewed
Mar 27, 2023
| @@ -65,6 +68,9 @@ provide('hero-image-slot-exists', heroImageSlotExists) | |||
| <template #doc-footer-before><slot name="doc-footer-before" /></template> | |||
| <template #doc-before><slot name="doc-before" /></template> | |||
| <template #doc-after><slot name="doc-after" /></template> | |||
| <template #doc-top><slot name="doc-top" /></template> | |||
| <template #doc-bottom><slot name="doc-bottom" /></template> | |||
|
|
|||
brc-dd
approved these changes
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for some extra theming abilities, such as a wide header for a page.
Hope you will consider this super simple PR. These two slots will allow for some extra customization across the theme regardless of the content type.