chore: rename slot variables in tests #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
force-pushed
the
chore/rename-slot-variables
branch
from
345a006
to
763b666
Compare
Volar is not happy with the variable names `boolean`, `string` and `object`.
cexbrayat
force-pushed
the
chore/rename-slot-variables
branch
from
763b666
to
976835e
Compare
cexbrayat
added a commit
to cexbrayat/vue-test-utils-next
that referenced
this pull request
Jul 15, 2021
Now that vuejs/language-tools#253 is fixed in vue-tsc v0.21.0, we can remove the workaround we had to disbale Volar on the unit tests. It surfaced a few issues in the components that were added in the meantime, but these issues have been fixed by PR vuejs#756 vuejs#758 and vuejs#759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volar is not happy with the variable names
boolean,stringandobject.