fix: find component by its definition when using stub without name #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afontcu
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
LGTM!
I was concerned with the situation where a not-stubbed component that doesn't render (by using a v-if="false" at root, for instance) might be found by using a stub. I checked it out and turns out we can already find() a hidden component, so nothing to worry about!
xanf
force-pushed
the
xanf-find-component-without-name-by-stub
branch
from
9c9e8bf
to
d767435
Compare
|
Rebased, should be ready to go |
lmiller1990
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #696
When we're stubbing component (no matter with
mountorshallow: true) we still want to find a component by searching original component definition