fix: Problem with stub props #610
Conversation
…oblem-with-stub-props
| expect(wrapper.html()).toEqual( | ||
| '<div>\n' + | ||
| ' <foo-stub class="bar" test-id="foo" dynamic="[object Object]"></foo-stub>\n' + | ||
| ' <foo-stub dynamic="[object Object]" class="bar" test-id="foo"></foo-stub>\n' + |
There was a problem hiding this comment.
Order of props and attributes is changed .....this is my concern...
If we need to keep this order... I'll try it !!
There was a problem hiding this comment.
The order of attributes has no specific meaning, so it's fine if it changes a bit. This is one of the things I dislike about snapshots; they often change, even if the component works the same.
There was a problem hiding this comment.
I got it !!
Thanks a lot !!
lmiller1990
left a comment
lmiller1990
left a comment
There was a problem hiding this comment.
Code seems fine - shallowMount is so complicated, lol.
You mention a problem - is that the order of the attributes? I don't think this is really a problem - the order isn't important for the actual behavior. Some people might need to update their snapshots. That's fine - the order of the props is not guaranteed to be deterministic, as far as I know.
| expect(wrapper.html()).toEqual( | ||
| '<div>\n' + | ||
| ' <foo-stub class="bar" test-id="foo" dynamic="[object Object]"></foo-stub>\n' + | ||
| ' <foo-stub dynamic="[object Object]" class="bar" test-id="foo"></foo-stub>\n' + |
There was a problem hiding this comment.
The order of attributes has no specific meaning, so it's fine if it changes a bit. This is one of the things I dislike about snapshots; they often change, even if the component works the same.
|
|
||
| const render = (ctx: ComponentPublicInstance) => { | ||
| return h(tag, props, renderStubDefaultSlot ? ctx.$slots : undefined) | ||
| return h(tag, ctx.$props, renderStubDefaultSlot ? ctx.$slots : undefined) |
src/stubs.ts
Outdated
| shallow: boolean = false, | ||
| renderStubDefaultSlot: boolean = false | ||
| ) { | ||
| const component: { [key: string]: ComponentOptions } = {} |
There was a problem hiding this comment.
You could write Record<string, ComponentOptions>.
There was a problem hiding this comment.
I got it !! I'll fix it soon !!
Yep, I think so too. It looks me a little time to find problems lol.
That's right. What I meant was the order of the attributes. |
|
I corrected the points you pointed out !! |
4 participants
For what ??
This pull request is for #530
why the issue happened ?
CreateStub was using props of transformVNodeArgs on renderFunction.
This code means that the firstProps is always used for render function.
Hence, if we use shallow or stub this, problem happened.