docs: using beforeRouteEnter with defineOptions #2131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
posva
reviewed
Feb 6, 2024
| ```vue | ||
| <script setup> | ||
| // Using defineOptions requires Vue 3.3+ | ||
| defineOptions({ |
There was a problem hiding this comment.
I'm not so sure about two things:
- The example uses
defineOptions()so it makes it look like you can use setup stuff insidebeforeRouteEnter() - I would not recommend using this navigation guard at the moment as I plan data loaders to be a much better approach to the same problem
There was a problem hiding this comment.
The potential confusion around variable scope is a really good point and not something I'd considered. While this is still something I'd be happy to do myself, it does muddy the waters from a docs perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition to the docs attempts to address two common problems:
beforeRouteEnterdoesn't have a Composition API function. This is often perceived as an oversight or mistake, as it isn't immediately obvious that such a function isn't possible.beforeRouteEnterif they're using the Composition API.