docs: explain per-route guards on nested routes #2130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
niceplugin
added a commit
to niceplugin/Vuejs-Router-KO
that referenced
this pull request
Feb 12, 2024
niceplugin
added a commit
to niceplugin/Vuejs-Router-KO
that referenced
this pull request
Feb 12, 2024
* docs: omitting parent components for nested routes (vuejs#2127) * docs: explain per-route guards on nested routes (vuejs#2130) * "경로"를 "라우트"로 단어 일괄 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2127, I had originally intended to include a note about per-route guards, but the specific functionality I was trying to reference doesn't appear to be documented, so I left it out.
This PR attempts to address that.
Specifically, when using nested routes, the
beforeEnterper-route guard can be placed on either the parent or the child route. There is some subtlety to exactly when those guards will be called, which I believe is intentional and worth documenting.I've also moved the final paragraph of that section into a
tip. The new content about nested routes left that final paragraph feeling like a strange jump to a separate topic, and I think thetipbox makes that less confusing.