Skip to content

Conversation

@trickstival
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this!
Can we add another test that check that multiple calls to the unsubscribe function does nothing? This test would also allow you to verify the problem I mentioned in the comment

@trickstival trickstival requested a review from posva December 22, 2019 14:33
@posva
Copy link
Member

posva commented Dec 22, 2019 via email

@trickstival
Copy link
Contributor Author

What is the _subscriptions for? I would rather not directly expose them Eduardo San Martin Morote

On 22 Dec 2019, at 15:33, Patrick @.***> wrote:  @posva Done — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

You're right. At first glance it was the way I found to test if the subscriptions were right. Now I changed it to use spies instead.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@posva posva merged commit ceb1cd1 into vuejs:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants