-
-
Notifications
You must be signed in to change notification settings - Fork 506
chore: use tsgo in development #5860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the development build process from tsc (TypeScript Compiler) to tsgo (TypeScript's experimental native compiler), aiming to improve build performance during development. The changes include updating build scripts, reorganizing the VSCode extension source structure, and configuring the workspace to use the experimental tsgo compiler.
Key Changes
- Replaced
tscwithtsgoin build and watch scripts across the workspace - Reorganized VSCode extension sources from
lib/tosrc/directory - Updated all devDependencies to use "latest" versions instead of pinned versions
Reviewed changes
Copilot reviewed 14 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated build/watch scripts to use tsgo, changed all devDependencies to "latest", updated packageManager version |
| tsconfig.json | Added reference to extensions/vscode tsconfig |
| extensions/vscode/tsconfig.json | Changed from noEmit to outDir/rootDir, added project references |
| extensions/vscode/src/* | New source files moved/created from lib directory (welcome.ts, config.ts, etc.) |
| extensions/vscode/package.json | Simplified build scripts, changed devDependencies to "latest", updated gen-ext-meta path |
| extensions/vscode/main.js | New entry point that tries out/ directory first, falls back to dist/ |
| extensions/vscode/rolldown.config.ts | Simplified config, removed development mode, always minifies output |
| .vscode/settings.json | Enabled typescript.experimental.useTsgo, removed vue.server.path and typescript.tsdk |
| .vscode/tasks.json | Simplified task definitions for build and watch |
| packages/language-server/lib/server.ts | Simplified getExistingLanguageServices to return synchronous array |
Comments suppressed due to low confidence (1)
extensions/vscode/src/extension.ts:25
- The variable 'serverPath' is changed from 'const' to 'let' to allow reassignment later in the code. However, the reassignment happens inside a conditional block where a new value might not always be assigned. Consider initializing it with the result of resolveServerPath() or ensuring all code paths properly handle the case when it remains undefined.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes:
tsgoinstead oftscin build and watch scriptstypescript.experimental.useTsgoin VSCode settings (requires installing https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.native-preview)tsgo -wIssues: