Skip to content

Conversation

@johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Dec 12, 2025

Changes:

Issues:

  • tsslint is no longer working in the IDE
  • Since the workspace has lost Vue language support, debugging can only be run for testing now

@johnsoncodehk johnsoncodehk merged commit 7b5032f into master Dec 12, 2025
17 checks passed
@johnsoncodehk johnsoncodehk deleted the use-tsgo branch December 12, 2025 19:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the development build process from tsc (TypeScript Compiler) to tsgo (TypeScript's experimental native compiler), aiming to improve build performance during development. The changes include updating build scripts, reorganizing the VSCode extension source structure, and configuring the workspace to use the experimental tsgo compiler.

Key Changes

  • Replaced tsc with tsgo in build and watch scripts across the workspace
  • Reorganized VSCode extension sources from lib/ to src/ directory
  • Updated all devDependencies to use "latest" versions instead of pinned versions

Reviewed changes

Copilot reviewed 14 out of 24 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
package.json Updated build/watch scripts to use tsgo, changed all devDependencies to "latest", updated packageManager version
tsconfig.json Added reference to extensions/vscode tsconfig
extensions/vscode/tsconfig.json Changed from noEmit to outDir/rootDir, added project references
extensions/vscode/src/* New source files moved/created from lib directory (welcome.ts, config.ts, etc.)
extensions/vscode/package.json Simplified build scripts, changed devDependencies to "latest", updated gen-ext-meta path
extensions/vscode/main.js New entry point that tries out/ directory first, falls back to dist/
extensions/vscode/rolldown.config.ts Simplified config, removed development mode, always minifies output
.vscode/settings.json Enabled typescript.experimental.useTsgo, removed vue.server.path and typescript.tsdk
.vscode/tasks.json Simplified task definitions for build and watch
packages/language-server/lib/server.ts Simplified getExistingLanguageServices to return synchronous array
Comments suppressed due to low confidence (1)

extensions/vscode/src/extension.ts:25

  • The variable 'serverPath' is changed from 'const' to 'let' to allow reassignment later in the code. However, the reassignment happens inside a conditional block where a new value might not always be assigned. Consider initializing it with the result of resolveServerPath() or ensuring all code paths properly handle the case when it remains undefined.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

johnsoncodehk added a commit that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants