fix: syntax highlight not work in template with lang="html" #5728
+20
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since defaults to the HTML language, I excluded
<* lang="html">from matching<template>.This fixes the issue where
<template lang="html">wasn’t highlighted correctly.Because in the original design the end in patterns can’t access the parent’s
endtag, it can’t pass the parent’s arbitrary end tag name down to child patterns forendchecks. So I addedtext.html.derivativeto everything underlang="html"(including the>of the opening tag). This only affects non-template tags (which should be edge cases?).Screenshot
Related
Fix #1756
Fix johnsoncodehk/volar-starter#9