Skip to content

fix: depend on exact volar version [v2] #5346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

tomblachut
Copy link
Contributor

@tomblachut tomblachut commented May 1, 2025

Patch versions of Volar are known to create incompatibilities with Vue Language Tools. This change fixes this problem for the @vue/language-server package downloaded from the npm registry.

For example something here volarjs/volar.js@v2.4.11...v2.4.12 breaks Vue Language Server 2.2.8, and npm will download the latest patch release of dependency. This doesn't show up in VSCode Extension, because Volar 2.4.11 was specified in pnpm-lock of vue-language-tools monorepo, but as far as I know it might affect all other editors.

Patch versions of Volar are known to create incompatibilities with Vue Language Tools. This change fixes this problem for the @vue/language-server package downloaded from the npm registry.
Copy link

pkg-pr-new bot commented May 1, 2025

Open in StackBlitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5346

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5346

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5346

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5346

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5346

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5346

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5346

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5346

commit: b046b19

@KazariEX KazariEX merged commit a36635f into vuejs:v2 May 1, 2025
5 checks passed
@tomblachut tomblachut deleted the v2/lock-volar-version branch May 1, 2025 21:50
@johnsoncodehk
Copy link
Member

Thanks 👍, we should have done this earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants