Skip to content

fix(language-core): should wrap item with Reactive on v-for #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 26, 2024
Merged

fix(language-core): should wrap item with Reactive on v-for #4902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
60f327f
fix: should wrap item with `Reactive` on v-for
KazariEX Oct 2, 2024
eb1cc85
test: update snapshot and case
KazariEX Oct 2, 2024
e1ab05a
fix: vue2
KazariEX Oct 26, 2024
ee6b390
Update main.vue
johnsoncodehk Oct 26, 2024
3378d1c
Update main.vue
johnsoncodehk Oct 26, 2024
6bf8f48
Merge remote-tracking branch 'upstream/master' into fix/v-for-reactive
KazariEX Oct 26, 2024
d11d10c
Merge branch 'fix/v-for-reactive' of https://github.com/KazariEX/vuej…
KazariEX Oct 26, 2024
87008bd
Update globalTypes.ts
johnsoncodehk Oct 26, 2024
b3543ed
test: not exclude
KazariEX Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/language-core/lib/codegen/globalTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,11 @@ export function generateGlobalTypes(lib: string, target: number, strictTemplates
function __VLS_getVForSourceType(source: number): [number, number, number][];
function __VLS_getVForSourceType(source: string): [string, number, number][];
function __VLS_getVForSourceType<T extends any[]>(source: T): [
item: T[number],
item: ${(
target >= 3 ? `import('${lib}').Reactive<T[number]>` :
target >= 2.7 ? `import('${lib}').UnwrapNestedRefs<T[number]>` :
`T[number]`
)},
key: number,
index: number,
][];
Expand Down
2 changes: 1 addition & 1 deletion packages/tsc/tests/__snapshots__/dts.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ declare const _default: <Row extends BaseRow>(__VLS_props: NonNullable<Awaited<t
attrs: any;
slots: {
default?(_: {
row: Row;
row: import("vue").Reactive<Row>;
}): any;
};
emit: {};
Expand Down
10 changes: 5 additions & 5 deletions test-workspace/tsc/passedFixtures/vue3/#3204/main.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<script setup lang="ts" generic="T">
<script setup lang="ts" generic="T extends { foo: number }">
import { exactType } from '../../shared';

const props = withDefaults(defineProps<{
Expand All @@ -11,12 +11,12 @@ const props = withDefaults(defineProps<{

<template>
<div v-for="item of list">
{{ exactType(item, {} as T) }}
{{ exactType(item.foo, {} as number) }}
</div>
<div v-for="item of props.list">
{{ exactType(item, {} as T) }}
{{ exactType(item.foo, {} as number) }}
</div>
<div v-for="item of $props.list">
{{ exactType(item, {} as T) }}
{{ exactType(item.foo, {} as number) }}
</div>
</templat>
</template>