fix(language-core): any in templates if first checked file was not root #4526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#4452 could potentially break something else tho, but this fixes this problem for our case. |
daniluk4000
changed the title
daniluk4000
changed the title
…file was not root
Member
|
The current test infrastructure makes it difficult to add test cases for this bug, but the change looks good to me, thanks for looking into it! |
johnsoncodehk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4470.
When debugging I found that our first file is our internal node modules component.
But since canonicalRootFileNamesVersion was set, and this file wasn't root, globalTypesHolder was never set.