refactor(language-core): remove experimentalAdditionalLanguageModules and deprecated APIs
#3907
Conversation
…s` and deprecated apis
| "experimentalAdditionalLanguageModules": { | ||
| "deprecated": true, | ||
| "type": "array", | ||
| "markdownDescription": "https://github.com/vuejs/language-tools/pull/2267" | ||
| }, |
There was a problem hiding this comment.
If it's removed then the property should be removed instead of marked as deprecated IMO.
If the idea is that the link provides some info about removal then it's a wrong link.
There was a problem hiding this comment.
The purpose of marking it as deprecated is to be able to prompt warnings. I would remove the description, but I agree it would be better to have a deprecated message.
There was a problem hiding this comment.
I've assumed that the schema uses "additionalProperties": false so that the removal would raise and error. But I see that it's not the case. I think that adding it would make sense so that this could be removed and also people would see issues if they mistype some option.
There was a problem hiding this comment.
I couldn't get "additionalProperties": false to work, please feel free to open a PR if you get it to work.
There was a problem hiding this comment.
additionalProperties might not work if there are multiple schemas extending the same object but then my question is: do deprecated properties really need to be separated into its own file? If they wouldn't then it would be easy to use additionalProperties: false.
BTW. deprecated is not a meant to be used for functionality that is removed but only for that that is still supported but discouraged. With additionalProperties:false we could express both removed and deprecated properties.
There was a problem hiding this comment.
I can confirm this works and implement by 777b0a1, thanks!
Changes
createLanguagesAPIcreateVueLanguageAPI rename tocreateVueLanguagePluginexperimentalAdditionalLanguageModules, alternatives will be provided (probably after v2 is released)