Skip to content

chore: Keep Nuxt's 'asyncData' and 'fetch' with 'data' #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ota-meshi merged 4 commits into from
Aug 17, 2019
Merged

chore: Keep Nuxt's 'asyncData' and 'fetch' with 'data' #823

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffc3e0e
chore: Keep Nuxt's 'asyncData' and 'fetch' with 'data'
rchl Feb 18, 2019
3aaa5e6
Update order per review
rchl Feb 18, 2019
1fdc10f
Add also 'head' property
rchl Feb 25, 2019
a1119c1
Change order of 'head'
rchl Feb 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/rules/order-in-components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,9 @@ const defaultOrder = [
'inheritAttrs',
'model',
['props', 'propsData'],
'data',
['asyncData', 'fetch', 'data'],
Copy link

@pi0 pi0 Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving fetch to the top of asyncData because it is more context less

Copy link
Contributor Author

@rchl rchl Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pi0 but as I understand, having asyncData and fetch in same array means the order can be freely chosen between those. Then it shouldn't be need for moving them around?

Copy link
Contributor Author

@rchl rchl Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have actually updated to have them in explicit order.

'computed',
'watch',
'asyncData',
'fetch',
'LIFECYCLE_HOOKS',
'methods',
['template', 'render'],
Expand Down