Skip to content

Conversation

@armano2
Copy link
Contributor

@armano2 armano2 commented Nov 18, 2018

Make sure that --fix-type cli parameter works with our plugin

https://eslint.org/docs/developer-guide/working-with-rules#rule-basics

Make sure that --fix-type cli parameter works with our plugin
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

I have some suggestions for the type. Would you take a look?

@armano2
Copy link
Contributor Author

armano2 commented Nov 19, 2018

v-on-style and v-bind-style determines only how code looks not how its executed

@mysticatea
Copy link
Member

mysticatea commented Nov 19, 2018

Those two appear on vue-eslint-parser's AST as shorthand property, but indeed, those don't change semantics.

Hm, It's OK.

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@michalsnik michalsnik merged commit b18d351 into vuejs:master Nov 23, 2018
@armano2 armano2 deleted the fix-type branch November 23, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants