Skip to content

Fix: unintentional disabling #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2018
Merged

Fix: unintentional disabling #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rules/comment-directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
// Helpers
// -----------------------------------------------------------------------------

const COMMENT_DIRECTIVE_B = /^\s*(eslint-(?:en|dis)able)\s*(?:(\S|\S[\s\S]*\S)\s*)?$/
const COMMENT_DIRECTIVE_L = /^\s*(eslint-disable(?:-next)?-line)\s*(?:(\S|\S[\s\S]*\S)\s*)?$/
const COMMENT_DIRECTIVE_B = /^\s*(eslint-(?:en|dis)able)(?:\s+(\S|\S[\s\S]*\S))?\s*$/
const COMMENT_DIRECTIVE_L = /^\s*(eslint-disable(?:-next)?-line)(?:\s+(\S|\S[\s\S]*\S))?\s*$/

/**
* Parse a given comment.
Expand Down
17 changes: 17 additions & 0 deletions tests/lib/rules/comment-directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,5 +191,22 @@ describe('comment-directive', () => {
assert.deepEqual(messages[0].ruleId, 'vue/no-parsing-error')
assert.deepEqual(messages[1].ruleId, 'vue/no-duplicate-attributes')
})

it('should affect only the next line', () => {
const code = `
<template>
<!-- eslint-disable-next-line vue/no-parsing-error, vue/no-duplicate-attributes -->
<div id id="a">Hello</div>
<div id id="b">Hello</div>
</template>
`
const messages = linter.executeOnText(code, 'test.vue').results[0].messages

assert.deepEqual(messages.length, 2)
assert.deepEqual(messages[0].ruleId, 'vue/no-parsing-error')
assert.deepEqual(messages[0].line, 5)
assert.deepEqual(messages[1].ruleId, 'vue/no-duplicate-attributes')
assert.deepEqual(messages[1].line, 5)
})
})
})