Skip to content

refactor: use regexp-groups to simplify ignores #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FloEdelmann merged 8 commits into from
Jul 9, 2025
Merged

refactor: use regexp-groups to simplify ignores #2776

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f824823
refactor: use regexp-groups to simplify ignores (POC)
ST-DDT Jul 1, 2025
8570e6c
chore: rename
ST-DDT Jul 2, 2025
2dedddb
Apply suggestions from code review
ST-DDT Jul 2, 2025
cb9a52f
Merge branch 'master' into reafactor/regexp-group
ST-DDT Jul 2, 2025
dd474bb
refactor: replace regexp loops with regexpGroupMatchers
ST-DDT Jul 3, 2025
c58cac2
chore: edit after review
ST-DDT Jul 9, 2025
428c873
Merge branch 'master' into reafactor/regexp-group
ST-DDT Jul 9, 2025
b56eec9
Update tests/lib/utils/regexp.js
ST-DDT Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: rename
  • Loading branch information
@ST-DDT
ST-DDT committed Jul 2, 2025
commit 8570e6c9ad0f95696f9f7d47813e1f608267075f
4 changes: 2 additions & 2 deletions lib/rules/syntaxes/slot-attribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = {
/** @type {{ ignore: string[] }} */
const options = context.options[0] || {}
const { ignore = [] } = options
const ignoreGroupMatcher = regexp.toRegExpGroupMatcher(ignore)
const isAnyIgnored = regexp.toRegExpGroupMatcher(ignore)

const sourceCode = context.getSourceCode()
const tokenStore =
Expand Down Expand Up @@ -126,7 +126,7 @@ module.exports = {
const componentName = slotAttr.parent.parent.rawName

if (
ignoreGroupMatcher(
isAnyIgnored(
componentName,
casing.pascalCase(componentName),
casing.kebabCase(componentName)
Expand Down