Skip to content

Add support for defineModel #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Add support for defineModel #2360

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
783fcd6
Add support for defineModel
ota-meshi Jan 10, 2024
bea21a7
fixed rules related to ref
ota-meshi Jan 10, 2024
56bb759
fix require-prop-types.js
ota-meshi Jan 10, 2024
5064748
Apply suggestions from code review
ota-meshi Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix require-prop-types.js
  • Loading branch information
@ota-meshi
ota-meshi committed Jan 10, 2024
commit 56bb7594c9ef8827ca5aa3e5590004b5c29b8c9e
10 changes: 2 additions & 8 deletions lib/rules/require-prop-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,8 @@ module.exports = {
if (prop.type !== 'object' && prop.type !== 'array') {
return
}
let hasType

if (prop.type === 'array') {
hasType = false
} else {
const { value } = prop
hasType = optionHasType(value) ?? true
}
const hasType =
prop.type === 'array' ? false : optionHasType(prop.value) ?? true

if (!hasType) {
const { node, propName } = prop
Expand Down