fix: [vue/component-name-in-template-casing] False positive for dynamic component in template #2069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
requested changes
Jan 2, 2023
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
I don't think that built-in components should always be skipped. Rather, type-only imports should always be ignored in <script setup> for this rule.
Contributor
Author
|
@FloEdelmann Thank you for your review. I understood the expected behavior of this issue. I will fix it so that type-only imports are ignored. |
Contributor
Author
|
@FloEdelmann I fixed to skip the check if components is type-only import. Could you review it again? |
FloEdelmann
approved these changes
Jan 7, 2023
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Looks good to me now. Thanks for fixing!
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified at Jan. 07.
Issue
This pull request is a fix for issue #2048.
How to fixed
Linter check is ignored if type-only import and registeredComponentsOnly=true.
The logic to check whether type-only import or not is the same as for no-undef-components.